add xpu tuning to CE#645
Merged
shivam15s merged 2 commits intolinkedin:mainfrom Apr 2, 2025
Merged
Conversation
Contributor
Author
|
Very similar to #647 |
shivam15s
approved these changes
Apr 2, 2025
shivam15s
pushed a commit
that referenced
this pull request
Apr 2, 2025
## Summary Tuning on XPU: In fused linear JSD, if device is xpu, set MAX_FUSED_SIZE to 4096 instead of default 65536 // 2. This gives slightly better performance on xpu. Very similar to #645 ## Testing Done - Hardware Type: Intel(R) Data Center GPU Max 1550 - [x] run `make test` to ensure correctness - [x] run `make checkstyle` to ensure code style - [x] run `make test-convergence` to ensure convergence
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Tuning on XPU: In cross-entropy, if device is
xpu, setMAX_FUSED_SIZEto4096instead of default65536 // 2. This gives slightly better performance on xpu.Testing Done
make testto ensure correctnessmake checkstyleto ensure code stylemake test-convergenceto ensure convergence